-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove '--rebase' option for 'mike deploy' #4171
Conversation
This option is not supported in Mike 2.0. It is unlikely that the repo will need to be rebased anyway, because it has just been fetched.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8f2c8e3 small_tests_25 / small_tests / 8f2c8e3 small_tests_26 / small_tests / 8f2c8e3 small_tests_26_arm64 / small_tests / 8f2c8e3 ldap_mnesia_26 / ldap_mnesia / 8f2c8e3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3 dynamic_domains_mysql_redis_26 / mysql_redis / 8f2c8e3 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8f2c8e3 ldap_mnesia_25 / ldap_mnesia / 8f2c8e3 internal_mnesia_26 / internal_mnesia / 8f2c8e3 mysql_redis_26 / mysql_redis / 8f2c8e3 pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3 graphql_session_SUITE:admin_session:admin_session_cli:admin_list_users_with_status{error,
{{assertEqual,
[{module,graphql_session_SUITE},
{line,591},
{expression,"lists : sort ( ActualJIDs )"},
{expected,
[<<"alice_admin_list_users_with_status_1264@localhost.bis/res1">>]},
{value,[]}]},
[{graphql_session_SUITE,check_users,2,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,591}]},
{graphql_session_SUITE,admin_list_users_with_status_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
{line,422}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8f2c8e3 pgsql_cets_26 / pgsql_cets / 8f2c8e3 pgsql_mnesia_26 / pgsql_mnesia / 8f2c8e3 mssql_mnesia_26 / odbc_mssql_mnesia / 8f2c8e3 pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4171 +/- ##
==========================================
+ Coverage 84.08% 84.10% +0.01%
==========================================
Files 564 564
Lines 34064 34064
==========================================
+ Hits 28644 28650 +6
+ Misses 5420 5414 -6 ☔ View full report in Codecov by Sentry. |
This option is not supported in Mike 2.0, which led to doc build failures in
master
.It is unlikely that the repo will need to be rebased anyway, because it has just been fetched.
I tested the command manually with a SSH job in CircleCI, and it deploys the docs correctly.