Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '--rebase' option for 'mike deploy' #4171

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Nov 16, 2023

This option is not supported in Mike 2.0, which led to doc build failures in master.
It is unlikely that the repo will need to be rebased anyway, because it has just been fetched.

I tested the command manually with a SSH job in CircleCI, and it deploys the docs correctly.

This option is not supported in Mike 2.0.
It is unlikely that the repo will need to be rebased anyway,
because it has just been fetched.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 16, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 8f2c8e3
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 8f2c8e3
Reports root / small


small_tests_26 / small_tests / 8f2c8e3
Reports root / small


small_tests_26_arm64 / small_tests / 8f2c8e3
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 8f2c8e3
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 867 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3
Reports root/ big
OK: 4278 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 8f2c8e3
Reports root/ big
OK: 4246 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 8f2c8e3
Reports root/ big
OK: 4275 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 8f2c8e3
Reports root/ big
OK: 2311 / Failed: 0 / User-skipped: 867 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 8f2c8e3
Reports root/ big
OK: 2461 / Failed: 0 / User-skipped: 717 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 8f2c8e3
Reports root/ big
OK: 4647 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3
Reports root/ big
OK: 4666 / Failed: 1 / User-skipped: 119 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_cli:admin_list_users_with_status
{error,
  {{assertEqual,
     [{module,graphql_session_SUITE},
      {line,591},
      {expression,"lists : sort ( ActualJIDs )"},
      {expected,
        [<<"alice_admin_list_users_with_status_1264@localhost.bis/res1">>]},
      {value,[]}]},
   [{graphql_session_SUITE,check_users,2,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,591}]},
    {graphql_session_SUITE,admin_list_users_with_status_story,3,
      [{file,
         "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
       {line,422}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 8f2c8e3
Reports root/ big
OK: 4278 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 8f2c8e3
Reports root/ big
OK: 4665 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 8f2c8e3
Reports root/ big
OK: 4667 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 8f2c8e3
Reports root/ big
OK: 4664 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 8f2c8e3
Reports root/ big
OK: 4667 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f739c24) 84.08% compared to head (8f2c8e3) 84.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   84.08%   84.10%   +0.01%     
==========================================
  Files         564      564              
  Lines       34064    34064              
==========================================
+ Hits        28644    28650       +6     
+ Misses       5420     5414       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review November 17, 2023 09:44
@arcusfelis arcusfelis merged commit 28f5644 into master Nov 17, 2023
4 checks passed
@arcusfelis arcusfelis deleted the update-mike-deploy branch November 17, 2023 09:45
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants